Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: take yum group name from env ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25810/1/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 596: ENGINE_URI, Line 597: ) Line 598: Line 599: ENGINE_PACKAGE_NAME = 'ovirt-engine' Line 600: ENGINE_PACKAGE_SETUP_NAME = '%s-setup' % ENGINE_PACKAGE_NAME Maybe rename this one to UPGRADE_YUM_GROUP_NAME ? Line 601: UPGRADE_YUM_GROUP = 'ovirt-engine-3.4' Line 602: Line 603: @classproperty Line 604: def RPM_LOCK_LIST(self): -- To view, visit http://gerrit.ovirt.org/25810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95073ed917a5276b8e3a21fc2f2f1574139f04ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
