Lior Vernia has posted comments on this change. Change subject: webadmin: Aggregate error messages in Frontend.runMultipleActions() ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25837/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java: Line 966: success = true; Line 967: callback.executed(f); Line 968: } Line 969: Line 970: if (showErrorDialog && (!success) && (getEventsHandler() != null) Please note this line especially - I thought it was supposed to be this way originally, please correct me if I misunderstood. Line 971: && (getEventsHandler().isRaiseErrorModalPanel(actionType, result.getFault()))) { Line 972: if (result.getCanDoActionMessages().size() <= 1) { Line 973: String errorMessage = !result.getCanDoAction() || !result.getCanDoActionMessages().isEmpty() Line 974: ? getRunActionErrorMessage(result.getCanDoActionMessages()) : result.getFault().getMessage(); -- To view, visit http://gerrit.ovirt.org/25837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0236b7d9316dff3d9bd22f2127318eefc37bbda1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
