Allon Mureinik has uploaded a new change for review.

Change subject: core: UpdateVmDiskCommand singletonList
......................................................................

core: UpdateVmDiskCommand singletonList

Use the better performing Collections.singletonList instead of
Arrays.asList.

Change-Id: I68f3a676fe51317499783d0f62239069574ae1f2
Signed-off-by: Allon Mureinik <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/25843/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
index eb313db..4b2acd72 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
@@ -1,7 +1,7 @@
 package org.ovirt.engine.core.bll;
 
 import java.util.ArrayList;
-import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.LinkedList;
@@ -282,7 +282,7 @@
             }
 
             for (VM vm : getVmsDiskPluggedTo()) {
-                if (!VdcActionUtils.canExecute(Arrays.asList(vm), VM.class, 
VdcActionType.ExtendImageSize)) {
+                if (!VdcActionUtils.canExecute(Collections.singletonList(vm), 
VM.class, VdcActionType.ExtendImageSize)) {
                     return 
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL, 
LocalizedVmStatus.from(vm.getStatus()));
                 }
             }


-- 
To view, visit http://gerrit.ovirt.org/25843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68f3a676fe51317499783d0f62239069574ae1f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to