Lior Vernia has uploaded a new change for review. Change subject: webadmin: Aggregate errors when importing networks ......................................................................
webadmin: Aggregate errors when importing networks When importing several networks, some imports may fail while others succeed; all failures should be aggregated into one dialog to be surveyed by the user. Change-Id: I5230847a055a8a58f4596290e9ee5d2af2b09784 Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 2 files changed, 15 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/25838/1 diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java index e0ae692..d8722f8 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java @@ -601,8 +601,8 @@ } /** - * A convenience method that calls {@link #runMultipleActions(VdcActionType, List, List, Object)} with just a single - * callback to be called when all actions have succeeded. + * A convenience method that calls {@link #runMultipleActions(VdcActionType, List, List, Object, boolean)} with just a single + * callback to be called when all actions have succeeded and no error aggregation. * * @param actionType The action to be repeated. * @param parameters The parameters of each action. @@ -627,7 +627,8 @@ callbacks[n - 1] = successCallback; runMultipleActions(actionType, parameters, new LinkedList<IFrontendActionAsyncCallback>(Arrays.asList(callbacks)), - state); + state, + false); } /** @@ -661,18 +662,20 @@ /** * A convenience method that calls - * {@link #runMultipleActions(List, List, List, IFrontendActionAsyncCallback, Object)} with just the one + * {@link #runMultipleActions(List, List, List, IFrontendActionAsyncCallback, Object, boolean)} with just the one * VdcActionType for all actions. * * @param actionType The action to be repeated. * @param parameters The parameters of each action. * @param callbacks The callback to be executed upon the success of each action. * @param state The state. + * @param aggregateErrors Whether error messages should be aggregated. */ public void runMultipleActions(final VdcActionType actionType, final List<VdcActionParametersBase> parameters, final List<IFrontendActionAsyncCallback> callbacks, - final Object state) { + final Object state, + boolean aggregateErrors) { if (parameters == null || parameters.isEmpty()) { return; } @@ -683,19 +686,21 @@ parameters, callbacks, null, - state); + state, + aggregateErrors); } /** - * Overloaded method for {@link #runMultipleActions(VdcActionType, List, List, Object)} with state = null. + * Overloaded method for {@link #runMultipleActions(VdcActionType, List, List, Object, boolean)} with state = null. * @param actionType The action to be repeated. * @param parameters The parameters of each action. * @param callbacks A list of callbacks. */ public void runMultipleActions(final VdcActionType actionType, final List<VdcActionParametersBase> parameters, - final List<IFrontendActionAsyncCallback> callbacks) { - runMultipleActions(actionType, parameters, callbacks, null); + final List<IFrontendActionAsyncCallback> callbacks, + final boolean aggregateErrors) { + runMultipleActions(actionType, parameters, callbacks, null, aggregateErrors); } /** diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java index e373da0..52e50da 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java @@ -211,7 +211,7 @@ }); } - Frontend.getInstance().runMultipleActions(VdcActionType.AddNetwork, multipleActionParameters, callbacks); + Frontend.getInstance().runMultipleActions(VdcActionType.AddNetwork, multipleActionParameters, callbacks, true); cancel(); } -- To view, visit http://gerrit.ovirt.org/25838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5230847a055a8a58f4596290e9ee5d2af2b09784 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
