Allon Mureinik has posted comments on this change. Change subject: core: Added uptime for the VDS entity ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25832/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java: Line 124: && (highlyAvailableIsConfigured == other.highlyAvailableIsConfigured) Line 125: && (highlyAvailableIsActive == other.highlyAvailableIsActive) Line 126: && (highlyAvailableGlobalMaintenance == other.highlyAvailableGlobalMaintenance) Line 127: && (highlyAvailableLocalMaintenance == other.highlyAvailableLocalMaintenance) Line 128: && uptime == other.uptime); This is a Long object, not a long primitive. Should be compared using ObjectUtils.objectsEqual(uptime, other.uptime) Line 129: } Line 130: Line 131: public Double getcpu_idle() { Line 132: return this.cpu_idle.doubleValue(); -- To view, visit http://gerrit.ovirt.org/25832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0bb08690718e9b6b6a8474d2f6be5f2e9eeeda Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
