Liron Ar has posted comments on this change. Change subject: core: further handling of multiple ovf disks for domain ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/25852/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java: Line 221: Line 222: int missingDiskCount = Config.<Integer> getValue(ConfigValues.StorageDomainOvfStoreCount) - ovfDiskCount; Line 223: Line 224: if (missingDiskCount > 0) { Line 225: Backend.getInstance().runInternalAction(VdcActionType.CreateOvfStoresForStorageDomain, > we should have a wrapper for the annoying Backend.getInstance().runInternal changed to getBackend() Line 226: new CreateOvfStoresForStorageDomainCommandParameters(getParameters().getStoragePoolId(), Line 227: getParameters().getStorageDomainId(), missingDiskCount)); Line 228: } Line 229: http://gerrit.ovirt.org/#/c/25852/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOvfStoresForStorageDomainCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOvfStoresForStorageDomainCommandParameters.java: Line 13: this.storesCount = storesCount; Line 14: } Line 15: Line 16: public int getStoresCount() { Line 17: > please remove this blank line Done Line 18: return storesCount; Line 19: } Line 20: Line 21: public void setStoresCount(int storesCount) { -- To view, visit http://gerrit.ovirt.org/25852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e54ca3781a301b72dc76b0dc014cf017a63e94e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
