Liron Ar has posted comments on this change. Change subject: core: UpdaveVmDiskCommand: don't shadow members ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/25841/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 168: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE); Line 169: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM_DISK); Line 170: } Line 171: Line 172: protected boolean validatePciAndIdeLimit() { now the check will run on a different list - vmsDiskPluggedTo instead of vmsDiskOrSnapshotPluggedTo which is wrong Line 173: for (VM vm : vmsDiskPluggedTo) { Line 174: List<VmNic> allVmInterfaces = getVmNicDao().getAllForVm(vm.getId()); Line 175: List<Disk> allVmDisks = new LinkedList<Disk>(getOtherVmDisks(vm.getId())); Line 176: allVmDisks.add(getNewDisk()); Line 557: protected boolean shouldUpdateReadOnly() { Line 558: return !vmDeviceForVm.getIsReadOnly().equals(getNewDisk().getReadOnly()); Line 559: } Line 560: Line 561: private boolean isAtLeastOneVmIsNotDown() { now the check will run on a different list - vmsDiskPluggedTo instead of vmsDiskOrSnapshotPluggedTo which is wrong Line 562: for (VM vm : vmsDiskPluggedTo) { Line 563: if (vm.getStatus() != VMStatus.Down) { Line 564: return true; Line 565: } -- To view, visit http://gerrit.ovirt.org/25841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9373239dda65c4d498bbafa714575827be9554f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
