Liron Ar has posted comments on this change. Change subject: core: Rename UpdateVmDiskCommand CDA methods ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25846/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 531: return getNewDisk().getDiskStorageType() == DiskStorageType.IMAGE && Line 532: vmDeviceForVm.getSnapshotId() == null && getNewDisk().getSize() != getOldDisk().getSize(); Line 533: } Line 534: Line 535: private boolean updateRuntimeParametersRequested() { i think that this name should be changed or restored to the previous name (not talking about the "Requested" change) Line 536: return updateDiskRuntimeParametersRequested() || updateImageRuntimeParametersRequested(); Line 537: } Line 538: Line 539: private boolean updateDiskRuntimeParametersRequested() { Line 545: getOldDisk().getSgio() != getNewDisk().getSgio() || Line 546: !StringUtils.equals(getOldDisk().getDiskDescription(), getNewDisk().getDiskDescription()); Line 547: } Line 548: Line 549: private boolean updateImageRuntimeParametersRequested() { same Line 550: if (getOldDisk().getDiskStorageType() != DiskStorageType.IMAGE) { Line 551: return false; Line 552: } Line 553: Guid oldQuotaId = ((DiskImage) getOldDisk()).getQuotaId(); -- To view, visit http://gerrit.ovirt.org/25846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91789866212b88e39b2e133c2d29c57475a7a624 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
