Liron Ar has posted comments on this change. Change subject: core: UpdateVmDiskCommand explicit member init ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25844/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 61: /** Line 62: * vm device for the given vm and disk Line 63: */ Line 64: private VmDevice vmDeviceForVm; Line 65: private Disk oldDisk = null; there shouldn't be a warning as members will be default initialized with null, set it is unneeded. Line 66: Line 67: public UpdateVmDiskCommand(T parameters) { Line 68: super(parameters); Line 69: loadVmDiskAttachedToInfo(); -- To view, visit http://gerrit.ovirt.org/25844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35e8ffd55cc1f3a243538c85830b6fe14cc2104d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
