Tal Nisan has posted comments on this change. Change subject: webadmin: Added a number of VMs in clusters general details sub tab ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25859/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java: Line 243: setResiliencePolicy(vdsGroup.getMigrateOnError()); Line 244: setEmulatedMachine(vdsGroup.getEmulatedMachine()); Line 245: setCompatibilityVersion(vdsGroup.getcompatibility_version().getValue()); Line 246: generateClusterType(vdsGroup.supportsGlusterService(), vdsGroup.supportsVirtService()); Line 247: AsyncDataProvider.getNumberOfVmsInCluster(new AsyncQuery(this, new INewAsyncCallback() { > is it called on each refresh? No, only on entity change Line 248: @Override Line 249: public void onSuccess(Object model, Object returnValue) { Line 250: setNumberOfVms((Integer) ((VdcQueryReturnValue) returnValue).getReturnValue()); Line 251: } http://gerrit.ovirt.org/#/c/25859/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java: Line 35: TextBoxLabel noOfVolumesDown = new TextBoxLabel(); Line 36: TextBoxLabel compatibilityVersion = new TextBoxLabel(); Line 37: TextBoxLabel emulatedMachine = new TextBoxLabel(); Line 38: Line 39: @Path("numberOfVms") > it should work without declaring the path explicitly (as it's the same as t Correct, removed Line 40: TextBoxLabel numberOfVms = new TextBoxLabel(); Line 41: Line 42: private final Driver driver = GWT.create(Driver.class); Line 43: -- To view, visit http://gerrit.ovirt.org/25859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I679f4b44aec3614e3ec046affc7a6dc5437b26e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
