Fabian Deutsch has posted comments on this change. Change subject: Keep everything in /var/log ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25878/1/ovirt-node-plugin-vdsm.spec.in File ovirt-node-plugin-vdsm.spec.in: Line 61: sed -i 's#/sbin/chkconfig \$srv off##' /etc/rc.d/init.d/vdsmd Line 62: Line 63: # Keep all files in /var/log to keep vdsm log files Line 64: # https://bugzilla.redhat.com/show_bug.cgi?id=1055153 Line 65: sed -i '/var\/log$/ s/^dirs/files/' /etc/rwtab > Wouldn't it work to add a "files" line to a file under /etc/rwtab.d ? No, I don't think so - or it might be racy. The problem is that as soon as a dirs line is found the directory structure is copied to the tmpfs, and that empty structure is bind moutned over /var/log. So every later files line will not see the original log files - but only the empty fs structure. Looking at the fedora-readonly script: for file in /etc/rwtab /etc/rwtab.d/* /run/initramfs/rwtab ; do We see that rwtab is always the first in the row. Line 66: Line 67: # reserve vdsm port 54321 Line 68: augtool << \EOF_sysctl Line 69: set /files/etc/sysctl.conf/net.ipv4.ip_local_reserved_ports 54321 -- To view, visit http://gerrit.ovirt.org/25878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia99564bc10a09aa07fae995c3aef83b81b1c700f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
