Ori Liel has uploaded a new change for review. Change subject: restapi: Use StringBuilder for String concatenation ......................................................................
restapi: Use StringBuilder for String concatenation Change-Id: Iee94056b785ef76cffafd4b2d07ae001dfab7674 Signed-off-by: Ori Liel <[email protected]> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/25891/1 diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java index 5c5d240..eaf68cc 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java @@ -27,13 +27,13 @@ * @return unique Guid generated from the given strings. */ public static Guid generateGuidUsingMd5(String... args) { - String id = ""; + StringBuilder builder = new StringBuilder(); for (String arg : args) { - id = id + arg; + builder.append(arg); } byte[] hash; try { - hash = MessageDigest.getInstance(MD5_SECURITY_ALGORITHM).digest(id.getBytes()); + hash = MessageDigest.getInstance(MD5_SECURITY_ALGORITHM).digest(builder.toString().getBytes()); } catch (NoSuchAlgorithmException e) { throw new IllegalStateException(e); // never happens, MD5 algorithm exists } -- To view, visit http://gerrit.ovirt.org/25891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee94056b785ef76cffafd4b2d07ae001dfab7674 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
