Francesco Romani has uploaded a new change for review. Change subject: dbscripts: fix password field length ......................................................................
dbscripts: fix password field length the password column in the 'storage_server_connections' table has a different type with respect to the corresponding parameter of the Insertstorage_server_connection function. This trigger SQL exception doing the following: - configure an ISCSI data domain (bug triggered on the first one, but it should behave the same with the others too). - in the 'New domain' window, issue fill all the fields, most notably username and password, and do a manual discovery. - try to add the target which shows up as result of the discovery. This patch fixes this problem by enlarging the password field on the table, in order to let it hold the encrypted password. Bug-Url: https://bugzilla.redhat.com/1052839 Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Signed-off-by: Francesco Romani <[email protected]> --- M packaging/dbscripts/storages_san_sp.sql A packaging/dbscripts/upgrade/03_04_0690_change_storage_server_connections_password_length.sql 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/25893/1 diff --git a/packaging/dbscripts/storages_san_sp.sql b/packaging/dbscripts/storages_san_sp.sql index 6fd5ea4..f6cb640 100644 --- a/packaging/dbscripts/storages_san_sp.sql +++ b/packaging/dbscripts/storages_san_sp.sql @@ -464,7 +464,7 @@ v_port VARCHAR(50) , v_portal VARCHAR(50) , v_username VARCHAR(50) , - v_password VARCHAR(50)) RETURNS SETOF storage_server_connections STABLE + v_password text) RETURNS SETOF storage_server_connections STABLE AS $procedure$ BEGIN RETURN QUERY SELECT * diff --git a/packaging/dbscripts/upgrade/03_04_0690_change_storage_server_connections_password_length.sql b/packaging/dbscripts/upgrade/03_04_0690_change_storage_server_connections_password_length.sql new file mode 100644 index 0000000..f6cc388 --- /dev/null +++ b/packaging/dbscripts/upgrade/03_04_0690_change_storage_server_connections_password_length.sql @@ -0,0 +1,6 @@ +-- with ISCSI data domain, after a manual discovery of a +-- password protected target, the adding failed with SQL exception +-- due to the difference in length of the password field. + +SELECT fn_db_change_column_type('storage_server_connections','password','varchar','text'); + -- To view, visit http://gerrit.ovirt.org/25893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
