Moti Asayag has posted comments on this change. Change subject: Expose setting the number of vNIC queues ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25764/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 783: Line 784: -- Allow to specify SecurityGroups property for vNICs, containing either an empty string or a list of one or more comma seperated UUIDs. Line 785: select fn_db_update_config_value('CustomDeviceProperties', '{type=interface;prop={SecurityGroups=^(?:(?:[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}, *)*[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}|)$}}', '3.4'); Line 786: Line 787: select fn_db_update_config_value('CustomDeviceProperties', '{type=interface;prop={SecurityGroups=^(?:(?:[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}, *)*[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}|)$;queues=^[0-9]*$}}', '3.5'); The fn_db_update_config_value function will not do the trick, since the 3.5 is a new entry, therefore should be added. See line 593 for example: select fn_db_add_config_value('CustomDeviceProperties', '', '3.4'); There are two options here: 1. Add the next line after line 593: select fn_db_add_config_value('CustomDeviceProperties', '', '3.5'); 2. Add the update entry in a single call. I'd prefer the first option, since we get the chance to see all the values for the versions in a single view. Line 788: Line 789: Line 790: ------------------------------------------------------------------------------------ Line 791: -- Update only if default not changed section -- To view, visit http://gerrit.ovirt.org/25764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66aaa982687e0957449c43f4824d78e09b09243c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
