Francesco Romani has posted comments on this change. Change subject: dbscripts: fix password field length ......................................................................
Patch Set 1: Sandro: sql script numbering seems OK (not-overlapping), I explicitely renamed the number. Not aware of any issue, so please point me to them. Maor: as I said in the bugzilla comment: this bug was targeted for 3.4.0, and I mistankely thought it was merged already in the 3.4.0 branch, so I took the chance to backport it for 3.4.0 also. That said, This bug looks like a quite rare corner case and noone else has stumbled into it AFAIK, so I think there is no urgent need to merge in 3.4.0. If it makes into the release we're all good, otherwise it could wait 3.4.1. -- To view, visit http://gerrit.ovirt.org/25902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
