Lior Vernia has posted comments on this change. Change subject: webadmin: Show Guide Me before vNIC creation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25901/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 1996: setWindow(null); Line 1997: setGuideContext(returnValue.getActionReturnValue()); Line 1998: updateActionAvailability(); Line 1999: getGuideCommand().execute(); Line 2000: } > If I understand correctly, if the VM creation fails, the VM window will sti Yes, you're probably correct, good spot! Hopefully fixed in next patchset. How about the general concept of closing the dialog without waiting for the vNIC creation to finish? Look okay to you? Line 2001: super.executed(result); Line 2002: } Line 2003: }, this); Line 2004: } -- To view, visit http://gerrit.ovirt.org/25901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4bebb56613ebaed67377489448501ba9642adf6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
