Omer Frenkel has posted comments on this change. Change subject: core: osinfo - fix 2008 sysprep index type ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25933/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: osinfo - fix 2008 sysprep index type Line 8: Line 9: - sypsrep index for 2008 an onward is String now Line 10: - deump the osinfo internals to debug log now typo dump Line 11: Line 12: Bug-Url: https://bugzilla.redhat.com/1069096 Line 13: Change-Id: I28898444de5da404bc8fb20cd2fa134e6ff6d83f http://gerrit.ovirt.org/#/c/25933/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java: Line 57: emptyNode = preferences.node("emptyNode"); Line 58: buildIdToUnameLookup(); Line 59: buildBackCompatMapping(); Line 60: validateTree(); Line 61: log.debugFormat("Osinfo Repository:\n {0}", toString()); since toString() is doing some work, maybe only call it if log.debugEnabled() ? Line 62: } Line 63: Line 64: private void validateTree() { Line 65: try { -- To view, visit http://gerrit.ovirt.org/25933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28898444de5da404bc8fb20cd2fa134e6ff6d83f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
