Alexander Wels has posted comments on this change.

Change subject: engine: Add header to each response.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25937/2/backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml
File backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml:

Line 81: 
Line 82:   <filter-mapping>
Line 83:     <filter-name>HeaderFilter</filter-name>
Line 84:     <url-pattern>/*</url-pattern>
Line 85:   </filter-mapping>
> as long as headers are not put in the other filters... well ok... for now..
If other filters add headers then those simply show up as well. If other 
filters add the same headers, then there is a relationship and the order will 
be important. But at this point that is not the case.

The order in which filters are applied is the order in which they are defined 
in the web.xml (It becomes a little muddy when you define filters with 
annotations which we don't do).
Line 86: 
Line 87:   <filter-mapping>
Line 88:     <filter-name>LocaleFilter</filter-name>
Line 89:     <url-pattern>/*</url-pattern>


-- 
To view, visit http://gerrit.ovirt.org/25937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e9c26dddd0d0300d6b3d078ae763b78600f25d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to