Omer Frenkel has posted comments on this change. Change subject: core: update the committed memory properly ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25943/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 931: log.debug("vds::refreshVmList entered"); Line 932: } Line 933: Line 934: if (fetchRunningVms()) { Line 935: refreshCommitedMemory(); please add comment/doc that this method is using the _running list and has to be first Line 936: List<Guid> staleRunningVms = checkVmsStatusChanged(); Line 937: Line 938: proceedWatchdogEvents(); Line 939: Line 1917: // VMs' pending resources are cleared in powering up, so in launch state Line 1918: // we shouldn't include them as committed. Line 1919: if (vmDynamic.getStatus() != VMStatus.WaitForLaunch && Line 1920: vmDynamic.getStatus() != VMStatus.Down) { Line 1921: VM vm = _vmDict.get(vmDynamic.getId()); vm can be null Line 1922: memCommited += vm.getVmMemSizeMb(); Line 1923: memCommited += _vds.getGuestOverhead(); Line 1924: vmsCoresCount += vm.getNumOfCpus(); Line 1925: } -- To view, visit http://gerrit.ovirt.org/25943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
