Alon Bar-Lev has posted comments on this change. Change subject: aaa: changes to attach_user_to_su_role ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25932/5/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsDAOImpl.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsDAOImpl.java: Line 33: prepareStatement = connection.prepareStatement(actionQuery); Line 34: prepareStatement.setString(1, userId); Line 35: prepareStatement.setString(2, userName); Line 36: prepareStatement.setString(3, domain); Line 37: prepareStatement.setString(4, "SuperUser"); doesn't the mighty java code style requires a constant for each one time constant? don't get me wrong but it is ok... just noting. Line 38: result = prepareStatement.execute(); Line 39: } finally { Line 40: DbUtils.closeQuietly(prepareStatement, connection); Line 41: } -- To view, visit http://gerrit.ovirt.org/25932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee8f6b1fac8f2281f9a5195918eeddc8788a4d17 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
