Gilad Chaplik has posted comments on this change. Change subject: fixed generics in EnumTranslator, fixed typo ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25605/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-11 09:08:53 +0100 Line 6: Line 7: fixed generics in EnumTranslator, fixed typo Line 8: Line 9: Parameterized EnumTranslator could accept any type, not just Enums, which is wrong. Constructor accepted also any type, but it was expected (not reinforced) that this type will be Class<? extends Enum<?>>. > Each line of the comment should contain up to 75 chars. you can easily edit the comment in gerrit (pencil icon button next to 'Permalink') Line 10: --- Line 11: Notes/pending changes: public constructor should be probably removed, since it bypasses caching. Or, maybe better, the caching should be removed -- object creation should not pose a problem but I did not measure it. Method createAndTranslate should not be static -- there's not translate method. Line 12: Not fixed error: not handled nullpointer exception in 'get' when null is passed to constructor. Line 13: -- To view, visit http://gerrit.ovirt.org/25605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If835e719a497e7ab1db4fc4f9484354e838c60c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
