Oved Ourfali has uploaded a new change for review.

Change subject: ux: allow using password authentication on foreman hosts
......................................................................

ux: allow using password authentication on foreman hosts

Previous patch removed the ability to use password
authentication with external hosts provided by Foreman.
This patch fixes that issue by hiding this option only
when installation relevant properties are to be hidden.

Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9
Bug-Url: https://bugzilla.redhat.com/1079072
Signed-off-by: Oved Ourfali <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/26003/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
index b290c24..a957457 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
@@ -1657,10 +1657,13 @@
         getConsoleAddress().setEntity(vds.getConsoleAddress());
         getConsoleAddress().setIsChangable(consoleAddressEnabled);
 
-        getPkSection().setIsChangable(false);
-        getPkSection().setIsAvailable(false);
-        // Use public key when edit or approve host
-        setAuthenticationMethod(AuthenticationMethod.PublicKey);
+        if (!showInstallationProperties()) {
+            getPkSection().setIsChangable(false);
+            getPkSection().setIsAvailable(false);
+
+            // Use public key when edit or approve host
+            setAuthenticationMethod(AuthenticationMethod.PublicKey);
+        }
 
         setAllowChangeHost(vds);
 


-- 
To view, visit http://gerrit.ovirt.org/26003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to