Liron Ar has uploaded a new change for review. Change subject: core: last ovf store update ......................................................................
core: last ovf store update In a case in which the last ovf store was previously updated, we should attempt to update it only if update to any of the previous domains was succesfull. Otherwise, we can attempt to update it immediately as it doesn't contain any ovf data so there's no point to consider the other updates results. Change-Id: I21491330681c333faf9e97b3d348d2af8c2b2fb5 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/26006/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java index 64d83de..4f4ccfd 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java @@ -158,8 +158,10 @@ // it within the loop unless some other ovf store was updated successfully (we use it as best effort backup so // we'll // possibly have some ovf data on storage) - if (lastOvfStoreForUpdate.getFirst().getLastUpdated() == null) { + if (lastOvfStoreForUpdate.getFirst().getLastUpdated() != null) { domainOvfStoresInfoForUpdate.removeLast(); + } else { + lastOvfStoreForUpdate = null; } boolean shouldUpdateLastOvfStore = false; -- To view, visit http://gerrit.ovirt.org/26006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I21491330681c333faf9e97b3d348d2af8c2b2fb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
