Tal Nisan has uploaded a new change for review.

Change subject: webadmin: Fixed message when adding Posix domain when not 
supported
......................................................................

webadmin: Fixed message when adding Posix domain when not supported

The message when adding a Posix domain when it's not supported on the
cluster was broken and lacking the action type and entity type

Change-Id: I237e40dd325c7b36c4413eab48e3aed41c090c4f
Bug-Url: https://bugzilla.redhat.com/1074254
Signed-off-by: Tal Nisan <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/26010/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
index 2d4695d..65fdfd1 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
@@ -145,7 +145,6 @@
 
     @Override
     protected boolean canDoAction() {
-        addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
         boolean returnValue = super.canDoAction() && initializeVds() && 
checkStorageDomainNameLengthValid();
         if (returnValue && isStorageWithSameNameExists()) {
             
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NAME_ALREADY_EXIST);
@@ -236,4 +235,9 @@
         return super.getValidationGroups();
     }
 
+    @Override
+    protected void setActionMessageParameters() {
+        super.setActionMessageParameters();
+        addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
+    }
 }


-- 
To view, visit http://gerrit.ovirt.org/26010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I237e40dd325c7b36c4413eab48e3aed41c090c4f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to