Arik Hadas has posted comments on this change. Change subject: webadmin: warn when exporting template version if base is missing ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26000/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java: Line 219: Line 220: getTemplatesNotPresentOnExportDomain(); Line 221: } Line 222: Line 223: private void getTemplatesNotPresentOnExportDomain() This is a bit weird to call a method like a 'getter' while it is void.. how about rename it to something that would reflect its purpose better? Line 224: { Line 225: ExportVmModel model = (ExportVmModel) getWindow(); Line 226: Guid storageDomainId = ((StorageDomain) model.getStorage().getSelectedItem()).getId(); Line 227: -- To view, visit http://gerrit.ovirt.org/26000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028f9e98a31cca391e05e2e02c535f5f1b2068cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
