Moti Asayag has uploaded a new change for review. Change subject: engine: fix eclipse/findbugs warnings ......................................................................
engine: fix eclipse/findbugs warnings Change-Id: I280d5b697d8736cec4f5736cd3af25a0cf2db6c1 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java 3 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/26018/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java index e30fa81..30d2919 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java @@ -4,7 +4,7 @@ import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.compat.Guid; -public class InstallVdsCommand<T extends UpdateVdsActionParameters> extends UpdateVdsCommand { +public class InstallVdsCommand<T extends UpdateVdsActionParameters> extends UpdateVdsCommand<T> { public InstallVdsCommand(T parameters) { super(parameters, VdcActionType.InstallVdsInternal); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java index c2c515d..def4271 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java @@ -1,5 +1,8 @@ package org.ovirt.engine.core.bll; +import java.util.Collections; +import java.util.Map; + import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.bll.network.NetworkConfigurator; import org.ovirt.engine.core.common.AuditLogType; @@ -18,15 +21,11 @@ import org.ovirt.engine.core.utils.log.LogFactory; import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException; -import java.util.Collections; -import java.util.Map; - @LockIdNameAttribute @NonTransactiveCommandAttribute public class InstallVdsInternalCommand<T extends InstallVdsParameters> extends VdsCommand<T> { private static Log log = LogFactory.getLog(InstallVdsInternalCommand.class); - protected String _failureMessage = null; public InstallVdsInternalCommand(T parameters) { super(parameters); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java index 98d3d8c..6a39991 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java @@ -4,7 +4,7 @@ import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.compat.Guid; -public class UpgradeOvirtNodeCommand<T extends UpdateVdsActionParameters> extends UpdateVdsCommand { +public class UpgradeOvirtNodeCommand<T extends UpdateVdsActionParameters> extends UpdateVdsCommand<T> { public UpgradeOvirtNodeCommand(T parameters) { super(parameters, VdcActionType.UpgradeOvirtNodeInternal); @@ -13,5 +13,4 @@ protected UpgradeOvirtNodeCommand(Guid commandId) { super(commandId, VdcActionType.UpgradeOvirtNodeInternal); } - } -- To view, visit http://gerrit.ovirt.org/26018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I280d5b697d8736cec4f5736cd3af25a0cf2db6c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
