Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fields masking error in InstallVdsInternalCommand ......................................................................
findbugs: Fix fields masking error in InstallVdsInternalCommand The field _failureMessage is masking a field in the parent class VdsCommand the value is only read from the class and not written so it's definitely redundant Change-Id: Ie4d79f4ab03f9d10e2adfe012fca9d901cb6266c Signed-off-by: Tal Nisan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/26019/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java index c2c515d..0eaf39e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java @@ -26,7 +26,6 @@ public class InstallVdsInternalCommand<T extends InstallVdsParameters> extends VdsCommand<T> { private static Log log = LogFactory.getLog(InstallVdsInternalCommand.class); - protected String _failureMessage = null; public InstallVdsInternalCommand(T parameters) { super(parameters); -- To view, visit http://gerrit.ovirt.org/26019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie4d79f4ab03f9d10e2adfe012fca9d901cb6266c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
