Yaniv Dary has posted comments on this change. Change subject: packaging: setup: Always regenerate jasper conf ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25998/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 167: args=( Line 168: './js-ant', Line 169: '-DmasterPropsSource=%s' % config, Line 170: ( Line 171: cmd if productIndependent I think you should rename this to noSuffix or something more clear. Line 172: else '%s-%s' % ( Line 173: cmd, Line 174: self.environment[ Line 175: oreportscons.JasperEnv.JASPER_NAME -- To view, visit http://gerrit.ovirt.org/25998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I810cfae4e8ee4901e46fa49b46c7a8a41dde0bf1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
