Gilad Chaplik has posted comments on this change. Change subject: webadmin: new instance type dialog + instance type list ......................................................................
Patch Set 26: (2 comments) Code looks okay, no special comments. but I'd like to first verify, before I +2 it. please add screenshots (via http://tinypic.com/ or similar) http://gerrit.ovirt.org/#/c/21821/26/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 360: public ValueLabel<Integer> outOfxInPool; Line 361: Line 362: @UiField Line 363: @Ignore Line 364: public Label generalLabel; can you add a comment... general is too general :P Line 365: Line 366: @UiField(provided = true) Line 367: @Path(value = "timeZone.selectedItem") Line 368: @WithElementId("timeZone") http://gerrit.ovirt.org/#/c/21821/26/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml: Line 42: <t:content> Line 43: <g:SimplePanel addStyleNames="{style.panel}" ui:field="instanceTypesTabPanel" /> Line 44: </t:content> Line 45: </t:DialogTab> Line 46: </t:tab> replace w/s with tabs Line 47: </t:DialogTabPanel> Line 48: </d:content> Line 49: Line 50: <d:footerButton> -- To view, visit http://gerrit.ovirt.org/21821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09722a0c3879268a6c683d88630440b6f8d8f794 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
