Juan Hernandez has posted comments on this change. Change subject: restapi: Fix cloud-init host name ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26047/1/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 323: action.async: 'xs:boolean', action.vm.os.kernel: 'xs:string', action.grace_period.expiry: 'xs:long', Line 324: action.vm.display.type: 'xs:string', action.vm.stateless: 'xs:boolean', action.vm.os.cmdline: 'xs:string', Line 325: action.vm.domain.user.username: 'xs:string', action.pause: 'xs:boolean', Line 326: action.vm.os.boot--COLLECTION: {boot.dev: 'xs:string'},action.vm.domain.user.password: 'xs:string', Line 327: action.vm.initialization.cloud_init.host.address: 'xs:string', > it should be <name> IIUC It should probably be like that, but currently mapper takes the "address", not the "name". If we change to "name" that then we break backwards compatibility in the RESTAPI itself. Line 328: action.vm.initialization.cloud_init.network_configuration.nics.nic--COLLECTION: {nic.name: 'xs:string', Line 329: nic.boot_protocol: 'xs:string', Line 330: nic.network.address.ip: 'xs:string', Line 331: nic.network.address.netmask: 'xs:string', -- To view, visit http://gerrit.ovirt.org/26047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d3159cf476f881c1fe0e6955b1be44f69f94e58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
