Liran Zelkha has posted comments on this change. Change subject: core: Fix AuditLog check for existing log entries ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26028/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java: Line 48: public boolean getLegal() { Line 49: if (getUseTimout()) { Line 50: String keyForCheck = getkeyForCheck(); Line 51: if (!CacheManager.getTimeoutBaseCache().containsKey(keyForCheck)) { Line 52: CacheManager.getTimeoutBaseCache().put(keyForCheck, keyForCheck, getEndTime(), TimeUnit.MILLISECONDS); Can you break this line - not shown correctly in the new gerrit... Line 53: return true; Line 54: } Line 55: return false; Line 56: } -- To view, visit http://gerrit.ovirt.org/26028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94b777911eb1ff667be3dc8362bde5746d84824c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
