Arik Hadas has posted comments on this change. Change subject: core: Not Responding Treatment is broken ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26057/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 66: getParameters().setParentCommand(VdcActionType.VdsNotRespondingTreatment); Line 67: // Make sure that the StopVdsCommand that runs by the RestartVds Line 68: // don't write over our job, and disrupt marking the job status correctly Line 69: ExecutionContext ec = (ExecutionContext) ObjectUtils.clone(this.getExecutionContext()); Line 70: if (ec != null) please add braces ("{" & "}") Line 71: ec.setJob(this.getExecutionContext().getJob()); Line 72: Line 73: super.executeCommand(); Line 74: Line 71: ec.setJob(this.getExecutionContext().getJob()); Line 72: Line 73: super.executeCommand(); Line 74: Line 75: if (ec != null) same here Line 76: this.setExecutionContext(ec); Line 77: } else { Line 78: setCommandShouldBeLogged(false); Line 79: log.infoFormat("Host {0}({1}) not fenced since it's status is ok, or it doesn't exist anymore.", -- To view, visit http://gerrit.ovirt.org/26057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3871bd414509324d4178ea633ca4d7f9aae74ebf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
