Maor Lipchuk has posted comments on this change. Change subject: core[WIP]: Support detach Storage Domain with disks. ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/24286/5/packaging/dbscripts/disk_images_sp.sql File packaging/dbscripts/disk_images_sp.sql: Line 160: BEGIN Line 161: RETURN QUERY SELECT i.* Line 162: FROM images_storage_domain_view i Line 163: INNER JOIN storage_for_image_view ON i.image_guid = storage_for_image_view.image_id Line 164: WHERE active = TRUE > can be done Line 165: AND i.storage_id = v_storage_domain_id; Line 166: END; $procedure$ Line 167: LANGUAGE plpgsql; Line 168: http://gerrit.ovirt.org/#/c/24286/5/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 1034: ON i.image_guid = ISD.image_id) vms_with_disks_on_storage_domain ON vms.vm_guid = vms_with_disks_on_storage_domain.vm_guid Line 1035: INNER JOIN vm_device vd ON vd.vm_id = vms.vm_guid Line 1036: INNER JOIN images i ON i.image_group_id = vd.device_id Line 1037: INNER JOIN image_storage_domain_map on i.image_guid = image_storage_domain_map.image_id Line 1038: WHERE image_storage_domain_map.storage_domain_id <> v_storage_domain_id; > we are using all over != (although <> has the same meaning) done Line 1039: END; $procedure$ Line 1040: LANGUAGE plpgsql; Line 1041: Line 1042: Create or replace FUNCTION updateClusterForDetachedVMs(v_storage_domain_id UUID) -- To view, visit http://gerrit.ovirt.org/24286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
