Roy Golan has uploaded a new change for review. Change subject: core: log exception when OVF is corrupted ......................................................................
core: log exception when OVF is corrupted log to error the exception when failing to read the OVF Change-Id: Ibc25b6544a698df013fc6d6b2677d798408289a6 Bug-Url: https://bugzilla.redhat.com/1039468 Signed-off-by: Roy Golan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/26087/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java index 65c66dc..f9ea158 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java @@ -45,10 +45,12 @@ AuditLogableBase logable = new AuditLogableBase(); logable.addCustomValue("Template", ex.getName()); AuditLogDirector.log(logable, AuditLogType.IMPORTEXPORT_FAILED_TO_IMPORT_TEMPLATE); + log.errorFormat("failed to import a template {0}", ex.getMessage()); } catch (RuntimeException ex) { AuditLogableBase logable = new AuditLogableBase(); logable.addCustomValue("Template", "[Unknown name]"); AuditLogDirector.log(logable, AuditLogType.IMPORTEXPORT_FAILED_TO_IMPORT_TEMPLATE); + log.errorFormat("failed to import a template {0}", ex.getMessage()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java index 8ccdfc9..b1ba595 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java @@ -32,10 +32,12 @@ AuditLogableBase logable = new AuditLogableBase(); logable.addCustomValue("ImportedVmName", ex.getName()); AuditLogDirector.log(logable, AuditLogType.IMPORTEXPORT_FAILED_TO_IMPORT_VM); + log.errorFormat("failed to import a VM {0}", ex.getMessage()); } catch (RuntimeException ex) { AuditLogableBase logable = new AuditLogableBase(); logable.addCustomValue("ImportedVmName", "[Unknown name]"); AuditLogDirector.log(logable, AuditLogType.IMPORTEXPORT_FAILED_TO_IMPORT_VM); + log.errorFormat("failed to import a template {0}", ex.getMessage()); } } -- To view, visit http://gerrit.ovirt.org/26087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc25b6544a698df013fc6d6b2677d798408289a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
