Ravi Nori has posted comments on this change. Change subject: tools : engine-config is over writing the previous values ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25762/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java: Line 376: /** Line 377: * Concatenates the value of the given key for the given version. Is the actual execution of the Line 378: * 'merge' action ('-m', '--merge') Line 379: */ Line 380: private void mergeValue() throws Exception { > I have 2 questions here : Hi Eli, #1 can be done in a generic way #2 not so sure, how can it be done in a generic way? Can you elaborate with an example Line 381: String key = parser.getKey(); Line 382: String value = parser.getValue(); Line 383: String version = parser.getVersion(); Line 384: if (version == null) { -- To view, visit http://gerrit.ovirt.org/25762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
