Roy Golan has posted comments on this change. Change subject: webadmin: filter out unsupported architectures ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26078/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1446: } Line 1447: Line 1448: } Line 1449: Line 1450: private void filterUnsupportedArchs(ClusterModel clusterModel) { > Since I don't particularly like negations in method names I'd suggest somet no objections here. Line 1451: Collection<ArchitectureType> archsWithSupportingCpus = new HashSet<ArchitectureType>(); Line 1452: archsWithSupportingCpus.add(ArchitectureType.undefined); Line 1453: for (ServerCpu cpu: clusterModel.getCPU().getItems()) { Line 1454: archsWithSupportingCpus.add(cpu.getArchitecture()); -- To view, visit http://gerrit.ovirt.org/26078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7568e61882478f10bec614ddf514b32d23adc199 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
