Omer Frenkel has posted comments on this change. Change subject: engine: do not report VM on error if migration fails ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25090/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1560: } Line 1561: if (exitStatus == VmExitStatus.Normal) { Line 1562: return AuditLogType.VM_DOWN; Line 1563: } Line 1564: if (exitStatus == VmExitStatus.Error && exitReason == VmExitReason.MigrationFailed) { > Good point. in this case it doesnt sound like a good idea to put logic just on that, if someone will do a change in vdsm, the bug might return.. engine knows if this is source or dest host (cacheVm != null), it looks like we need to move the call from line 1525 to line 1528 but then im not sure we cover the case vm went down correctly on source (migration ended successfully) and crashed on dest before switching to up (migratingDesy->down) Line 1565: /* the VM is still up on the source host, so no need to report it in error */ Line 1566: return AuditLogType.VM_DOWN; Line 1567: } Line 1568: return AuditLogType.VM_DOWN_ERROR; -- To view, visit http://gerrit.ovirt.org/25090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I694dfa739af5edf37ae06b2dea2ad246f17777a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
