Tal Nisan has posted comments on this change. Change subject: core: Correct error message ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26009/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 673: VM_PINNING_DUPLICATE_DEFINITION=Cannot configure CPU pinning twice to the same vCPU. Line 674: VM_PINNING_PINNED_TO_NO_CPU=Cannot pin a vCPU to no pCPU. Line 675: ACTION_TYPE_FAILED_TEMPLATE_NOT_FOUND_ON_EXPORT_DOMAIN=Cannot export VM. Template ${TemplateName} does not exist on the export domain. if you want to export VM without its Template please use TemplateMustExists=false Line 676: ACTION_TYPE_FAILED_VM_NOT_FOUND_ON_EXPORT_DOMAIN=Cannot delete VM, VM not exists in export domain Line 677: ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL=The Action ${action} ${type} is not supported for this Cluster or Data Center compatibility version > Maybe we should add some kind of comma or quotation marks as so: Seems a bit strange imo, since it's a complete sentence, I mean it will be strage to have "The action, Add Storage, is not supported for this..." Line 678: ACTION_TYPE_FAILED_MAX_CPU_PER_SOCKET=Cannot ${action} ${type}. Max number of cpu per socket exceeded Line 679: ACTION_TYPE_FAILED_MAX_NUM_CPU=Cannot ${action} ${type}. Max number of cpu exceeded Line 680: ACTION_TYPE_FAILED_MAX_NUM_SOCKETS=Cannot ${action} ${type}. Max number of sockets exceeded Line 681: VMT_CANNOT_IMPORT_TEMPLATE_EXISTS=Import Template failed - Template Id already exist in the system. Please remove the Template (${TemplateName}) from the system first -- To view, visit http://gerrit.ovirt.org/26009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5517297e0de3350f3d62ab67cb908b4525e306d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
