Eli Mesika has posted comments on this change. Change subject: aaa: Changing ExternalId to String ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26134/1/packaging/dbscripts/upgrade/03_05_0180_change_external_id_to_string.sql File packaging/dbscripts/upgrade/03_05_0180_change_external_id_to_string.sql: Line 13: UPDATE users SET Line 14: external_id = substring(external_id from 3 for 8) || '-' || Line 15: substring(external_id from 11 for 4) || '-' || Line 16: substring(external_id from 15 for 4) || '-' || Line 17: substring(external_id from 19 for 4) || '-' || > i'll fix trailing whitespaces, not sure i understood the 2nd comment. agree , the upgrade mechanism will not let this script to run twice , therefor , no need to be re-entrant Line 18: substring(external_id from 23); -- To view, visit http://gerrit.ovirt.org/26134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e6be2e47518238f2011702ee9ef17071fc2b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
