Eli Mesika has posted comments on this change. Change subject: core: skipping DOWN hosts in PM proxy selection ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26096/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 277: VdsDynamic vdsDynamic = vds.getDynamicData(); Line 278: return ((vdsDynamic.getStatus() == VDSStatus.Down) Line 279: || (vdsDynamic.getStatus() == VDSStatus.Reboot) Line 280: || (vdsDynamic.getStatus() == VDSStatus.NonOperational Line 281: && vdsDynamic.getNonOperationalReason() == NonOperationalReason.NETWORK_UNREACHABLE)); > Please remove unnecessary brackets: Done Line 282: } Line 283: Line 284: private VDS getFenceProxy(final boolean onlyUpHost, final boolean filterSelf, final PMProxyOptions proxyOptions) { Line 285: List<VDS> hosts = DbFacade.getInstance().getVdsDao().getAll(); -- To view, visit http://gerrit.ovirt.org/26096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie12002cbdbf025d5e53b2283dee7b373dac2a0a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
