Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing DbUserCacheManager when to refresh users ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26132/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByQueryParameters.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByQueryParameters.java: Line 20: public LdapSearchByQueryParameters(String sessionId, String domain, LdapQueryData ldapQueryData) { Line 21: this(sessionId, domain, ldapQueryData, false); Line 22: } Line 23: Line 24: public LdapSearchByQueryParameters(String sessionId, String domain, LdapQueryData queryData, boolean populateGroups) { > shouldn't "queryData" for consistency be called ldapQueryData like above? Not crucial, but I don't mind fixing this. Line 25: super(sessionId, domain); Line 26: setLdapQueryData(queryData); Line 27: this.populateGroups = populateGroups; Line 28: } -- To view, visit http://gerrit.ovirt.org/26132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icec0ffa48671e4fed2b631a60db9dd226ad6d347 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Sven Kieske <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
