Juan Hernandez has posted comments on this change. Change subject: packaging: DO NOT MERGE: Moving Jboss configuration functions to separate module ......................................................................
Patch Set 1: > Is it possible to completely remove configuration functions? How would we set > the jdbc parameters that depend on user input? It is not possible at the moment, but I would like to remove/simplify most of them. For example, for the JDBC, instead of using XPath to modify the standalone.xml file we can add most of the required text to the engine-service.xml file and then do smaller modifications (see http://gerrit.ovirt.org/#patch,sidebyside,4416,6,packaging/fedora/engine-service.xml). For some modifications we can do them with a different mechanism, for example, instead of using XPath to add/modify large chunks of XML the file we we can use something like ${whatever} in the .xml file and something like "-Dwhatever=whatever" in the start script. -- To view, visit http://gerrit.ovirt.org/4841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68c069591d04234efb1ccd551a9cff2f7d5ba8a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
