Shahar Havivi has posted comments on this change. Change subject: engine: added proper instance type handling for the watchdog ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25088/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java: Line 206: VdcQueryReturnValue query = Line 207: getBackend().runInternalQuery(VdcQueryType.GetWatchdog, new IdQueryParameters(templateId)); Line 208: List<VmWatchdog> watchdogs = query.getReturnValue(); Line 209: if (watchdogs.isEmpty()) { Line 210: if (getParameters().getWatchdog() == null) { Consider reversion the check and commenting the else // else: do not update if this flag is not set This is findbugs comment for empty block Line 211: // nothing to do, no watchdog and no watchdog to create Line 212: } else { Line 213: WatchdogParameters parameters = new WatchdogParameters(); Line 214: parameters.setVm(false); -- To view, visit http://gerrit.ovirt.org/25088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd953828b7bc3ce1607377a7db28970f5ab7a03e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
