Juan Hernandez has posted comments on this change.

Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26225/1/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd:

Line 4033:     <xs:complexContent>
Line 4034:         <xs:extension base="BaseResource">
Line 4035:             <xs:sequence>
Line 4036:                 <xs:element name="connectionId" type="xs:string" 
minOccurs="1" maxOccurs="unbounded" />
Line 4037:                 <xs:element name="networkId" type="xs:string" 
minOccurs="1" maxOccurs="unbounded" />
It is my understanding that connectionId and networkId are references to 
"storageconnections" and "network" resources. When we need this kind of 
references in the RESTAPI we represent them as follows:

  <icsi_bond>
    <storage_connection id="..."/>
    <network id="..."/>
    ...
  </iscsi_bond>

So you should define the elements like this:

  <xs:element ref="storage_connection" .../>
  <xs:element ref="network" .../>
Line 4038:             </xs:sequence>
Line 4039:         </xs:extension>
Line 4040:     </xs:complexContent>
Line 4041:   </xs:complexType>


-- 
To view, visit http://gerrit.ovirt.org/26225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to