Shirly Radco has posted comments on this change. Change subject: reports: br7 report - added comments to queries ......................................................................
Patch Set 2: (12 comments) http://gerrit.ovirt.org/#/c/25179/2/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7+full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7 full details.jrxml.data: Line 54: FROM v3_4_configuration_history_clusters AS a Line 55: GROUP BY a.cluster_id Line 56: ) Line 57: ), Line 58: 'all' > Capitalize this to match below or change it the below. not done Line 59: ) Line 60: AS cluster_name, Line 61: ( Line 62: SELECT v3_4_configuration_history_clusters.delete_date Line 107: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 month' - interval '1 day' AS date) Line 108: WHEN $P{P_Period} = 2 Line 109: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '3 month' - interval '1 day' AS date) Line 110: WHEN $P{P_Period} = 3 Line 111: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 year' - interval '1 day' AS date) > Please drop a line in the AS because this is more than 80 chars. Done Line 112: END AS end_date, Line 113: ( Line 114: SELECT DISTINCT Line 115: COALESCE ( http://gerrit.ovirt.org/#/c/25179/2/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7_table.jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7_table.jrxml.data: Line 57: END Line 58: AS is_deleted, Line 59: SUM ( Line 60: CASE Line 61: -- If "Period" equals to "Daily" then "table_name" parameter equals to "hourly" else "daily" > Please drop a line because this is more than 80 chars. Done Line 62: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 2 Line 63: THEN Line 64: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) Line 65: ELSE 0 Line 60: CASE Line 61: -- If "Period" equals to "Daily" then "table_name" parameter equals to "hourly" else "daily" Line 62: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 2 Line 63: THEN Line 64: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > Please drop a line because this is more than 80 chars. Done Line 65: ELSE 0 Line 66: END Line 67: ) Line 68: AS Planned_Downtime_Mins, Line 69: SUM ( Line 70: CASE Line 71: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 3 Line 72: THEN Line 73: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > same as above Done Line 74: ELSE 0 Line 75: END Line 76: ) Line 77: AS Unplanned_Downtime_Mins, Line 78: SUM ( Line 79: CASE Line 80: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 1 Line 81: THEN Line 82: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > same as above Done Line 83: ELSE 0 Line 84: END Line 85: ) Line 86: AS Uptime_Mins, Line 148: SUM( Line 149: CASE Line 150: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 3 Line 151: THEN Line 152: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > Please drop a line because this is more than 80 chars. Done Line 153: ELSE 0 Line 154: END Line 155: ) Line 156: AS float http://gerrit.ovirt.org/#/c/25179/2/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/cluster_uptime_br7_jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/cluster_uptime_br7_jrxml.data: Line 40: <defaultValueExpression><![CDATA[$P{P_Period} == 0 ? "the_datetime" : "the_date"]]></defaultValueExpression> Line 41: </parameter> Line 42: <queryString language="SQL"> Line 43: <![CDATA[-- BR7 - Chart Details Line 44: -- This query returns for the host/s chosen by the user in the specific datacenter, > or cluster Done Line 45: -- the total Planned_Downtime, Unplanned_Downtime and Uptime and total time in minutes. Line 46: -- Not specifically for each host. Line 47: Line 48: SELECT Line 47: Line 48: SELECT Line 49: SUM ( Line 50: CASE Line 51: -- If "Period" equals to "Daily" then "table_name" parameter equals to "hourly" else "daily" > drop line Done Line 52: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 2 Line 53: THEN Line 54: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) Line 55: ELSE 0 Line 50: CASE Line 51: -- If "Period" equals to "Daily" then "table_name" parameter equals to "hourly" else "daily" Line 52: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 2 Line 53: THEN Line 54: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > drop line Done Line 55: ELSE 0 Line 56: END Line 57: ) Line 58: AS Planned_Downtime_Mins, Line 59: SUM ( Line 60: CASE Line 61: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 3 Line 62: THEN Line 63: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > drop line Done Line 64: ELSE 0 Line 65: END Line 66: ) Line 67: AS Unplanned_Downtime_Mins, Line 68: SUM ( Line 69: CASE Line 70: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 1 Line 71: THEN Line 72: COALESCE ( v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 ) > drop line Done Line 73: ELSE 0 Line 74: END Line 75: ) Line 76: AS Uptime_Mins, -- To view, visit http://gerrit.ovirt.org/25179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0693f93fb2d1e324dee238190118a378667c9da6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
