Shirly Radco has posted comments on this change. Change subject: reports: br47 report - added comments to queries ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/25060/3/packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data: Line 63: v3_4_configuration_history_storage_domains.storage_domain_id, Line 64: COALESCE ( a.value_localized, a.value ) AS storage_domain_type, Line 65: COALESCE ( b.value_localized, b.value ) AS storage_type, Line 66: -- The disk usage is usually calculated from the samples statistics table, so it will be most accurate. Line 67: -- But if the data is not available from the samples then the data will be taken from the daily statistics table > please break the lines. too long. Done Line 68: COALESCE ( Line 69: samples.available_disk_size_gb, Line 70: daily.available_disk_size_gb Line 71: ) Line 175: ) Line 176: ) Line 177: WHERE Line 178: -- Here we filter by the storage type chosen by the user Line 179: -- If "All" storage types were chosen by the user then the parameter "P_Storage_Type" equals to -1 > same Done Line 180: storage_domain_type = Line 181: CASE $P{P_Storage_Type} Line 182: WHEN -1 Line 183: THEN storage_domain_type Line 189: FROM v3_4_configuration_history_storage_domains AS a Line 190: GROUP BY a.storage_domain_id Line 191: ) Line 192: -- If the user chose not to view deleted entities then this parameter will be equal to "AND delete_date IS NULL" Line 193: -- Otherwise this will be equal to "Null" and all storage domains for this datacenter will be return in the query > same Done Line 194: $P!{active_storage}]]> Line 195: </queryString> Line 196: <field name="storage_domain_name" class="java.lang.String"/> Line 197: <field name="storage_domain_id" class="java.lang.Object"/> -- To view, visit http://gerrit.ovirt.org/25060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce5b40141765d1e25637741b6c5a02b12b208b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
