Alona Kaplan has posted comments on this change. Change subject: webadmin: Set default DC for import by tree selection ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25732/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java: Line 159: } Line 160: } Line 161: externalNetwork.getDataCenters().setItems(availableDataCenters); Line 162: externalNetwork.getDataCenters() Line 163: .setSelectedItem(availableDataCenters.contains(treeSelectedDc) ? treeSelectedDc According to List.contains documentation- it throws NullPointerException if the specified element is null and this list does not permit null elements. Although in this case it is LinkedList and it supports null elements, I prefer not counting on it. Please add a separate null check. Line 164: : Linq.firstOrDefault(availableDataCenters)); Line 165: Line 166: items.add(externalNetwork); Line 167: } -- To view, visit http://gerrit.ovirt.org/25732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0fc87737b151c6e39f2545e39516023b0851111 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
