Douglas Schilling Landgraf has posted comments on this change.

Change subject: spec: start/enable glusterd
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/26203/1/ovirt-node-plugin-vdsm.spec.in
File ovirt-node-plugin-vdsm.spec.in:

Line 100: %endif
Line 101: 
Line 102: %preun
Line 103: 
Line 104: %postun
> Normally we don't need %postun - because we don't uninstall ovirt-node-plug
agreed but better have it in case in the future we somehow change this.
Line 105: if [ $1 -eq 0 ]; then
Line 106: %if 0%{?with_gluster}
Line 107: %if ! 0%{?with_systemd}
Line 108:     service glusterd stop >/dev/null 2>&1 || :


-- 
To view, visit http://gerrit.ovirt.org/26203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica02b068914a8ae9aaf8c452175db969badc4e6e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Joey Boggs <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to