Fabian Deutsch has posted comments on this change. Change subject: engine_page: network is required to register tab ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Just a nitpick, functional no objections http://gerrit.ovirt.org/#/c/26228/1/src/engine_page.py File src/engine_page.py: Line 141: Line 142: page = ui.Page("page", ws) Line 143: page.buttons = [] Line 144: Line 145: if net_is_configured: you could even pull this part into the else branch above, that would save us this conditional. Line 146: page.buttons = [ Line 147: ui.SaveButton( Line 148: "action.register", Line 149: "Save & Register" -- To view, visit http://gerrit.ovirt.org/26228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2563804673954234f3c29fed80ca54fe195d35a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
