Daniel Erez has uploaded a new change for review. Change subject: core: RemoveSnapshotSingleDisk - use parent command type ......................................................................
core: RemoveSnapshotSingleDisk - use parent command type RemoveSnapshotSingleDiskCommand: use 'getParameters().getParentCommand()' instead of hard-coded VdcActionType.RemoveSnapshot (for re-using the RemoveSnapshotSingleDisk internal command). Change-Id: Iab4d6ce72f87ddd3b2e361cea13912147cba640c Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/26318/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java index d9b3da7..658a3a1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java @@ -5,7 +5,6 @@ import org.ovirt.engine.core.common.VdcObjectType; import org.ovirt.engine.core.common.action.ImagesContainterParametersBase; -import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.asynctasks.AsyncTaskType; import org.ovirt.engine.core.common.businessentities.DiskImage; import org.ovirt.engine.core.common.job.StepEnum; @@ -31,7 +30,7 @@ Guid storageDomainId = !CollectionUtils.isEmpty(getDiskImage().getStorageIds()) ? getDiskImage().getStorageIds().get(0) : Guid.Empty; - Guid taskId = persistAsyncTaskPlaceHolder(VdcActionType.RemoveSnapshot); + Guid taskId = persistAsyncTaskPlaceHolder(getParameters().getParentCommand()); VDSReturnValue vdsReturnValue = mergeSnapshots(storagePoolId, storageDomainId); if (vdsReturnValue != null && vdsReturnValue.getCreationInfo() != null) { getReturnValue().getInternalVdsmTaskIdList().add(createTask(taskId, vdsReturnValue, storageDomainId)); @@ -53,7 +52,7 @@ String message = ExecutionMessageDirector.resolveStepMessage(StepEnum.MERGE_SNAPSHOTS, getJobMessageProperties()); - return super.createTask(taskId, vdsReturnValue.getCreationInfo(), VdcActionType.RemoveSnapshot, + return super.createTask(taskId, vdsReturnValue.getCreationInfo(), getParameters().getParentCommand(), message, VdcObjectType.Storage, storageDomainId); } -- To view, visit http://gerrit.ovirt.org/26318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab4d6ce72f87ddd3b2e361cea13912147cba640c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
